Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg/HiiDatabaseDxe: Remove efivarstore check for string load… #10764

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

poloaegis83
Copy link
Contributor

@poloaegis83 poloaegis83 commented Feb 14, 2025

Description

Remove efivarstore IFR buffer check when string load default. In the case of varstore type IFR, it will be NULL.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

  1. Boot to both VarStore and EfiVarStore type IFR setup pages,
    check string load default function works for EfiVarStore type IFR pages.
  2. Entering every formset , should be load success without ASSERT.

Integration Instructions

N/A

@poloaegis83 poloaegis83 force-pushed the string_default_fix branch 2 times, most recently from 40bba2c to fad5854 Compare February 19, 2025 02:50
@lgao4 lgao4 added this to the edk2-stable202502 milestone Feb 19, 2025
@lgao4
Copy link
Contributor

lgao4 commented Feb 19, 2025

This PR fixes the issue introduced by #10568. Because #10568 has been merged, this PR will be required to be merged for this stable tag 202502.

@lgao4
Copy link
Contributor

lgao4 commented Feb 19, 2025

@mdkinney , @makubacki , @ardbiesheuvel , @leiflindholm , I suggest to merge this fix for stable tag 202502.

@makubacki
Copy link
Member

Including the commit that introduced the issue (cbe8a09) in this commit's message would be nice to more directly allow the issue to be tracked in history.

Remove efivarstore IFR buffer error when string load default.
In the case of varstore type IFR, it will be NULL,
just break into next opcode process.

Resolve issue from commit cbe8a09
varstore type IFR string might return status error
while execute ExtractConfig function.

Signed-off-by: Longhao Lee <[email protected]>
@poloaegis83
Copy link
Contributor Author

Including the commit that introduced the issue (cbe8a09) in this commit's message would be nice to more directly allow the issue to be tracked in history.

Add issue(cbe8a09) description in commit message.

@lgao4 lgao4 merged commit fbe0805 into tianocore:master Feb 21, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants