Skip to content

Commit

Permalink
NetworkPkg/UefiPxeBcDxe: Bugfix for pxe driver
Browse files Browse the repository at this point in the history
Ensure the poniter is not null before free it

Signed-off-by: Bing Luo <[email protected]>
  • Loading branch information
Bing Luo committed Dec 28, 2024
1 parent 0986082 commit a2782d6
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
Submodule oniguruma updated 128 files
2 changes: 1 addition & 1 deletion MdePkg/Library/BaseFdtLib/libfdt
8 changes: 6 additions & 2 deletions NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ PxeBcDestroyIp4Children (
&Private->PxeBc,
NULL
);
FreePool (Private->Ip4Nic->DevicePath);
if(Private->Ip4Nic->DevicePath != NULL) {
FreePool (Private->Ip4Nic->DevicePath);
}

if (Private->Snp != NULL) {
//
Expand Down Expand Up @@ -407,7 +409,9 @@ PxeBcDestroyIp6Children (
&Private->PxeBc,
NULL
);
FreePool (Private->Ip6Nic->DevicePath);
if(Private->Ip6Nic->DevicePath != NULL) {
FreePool (Private->Ip6Nic->DevicePath);
}

if (Private->Snp != NULL) {
//
Expand Down
2 changes: 1 addition & 1 deletion RedfishPkg/Library/JsonLib/jansson
Submodule jansson updated 74 files
+15 −0 .github/dependabot.yml
+31 −0 .github/workflows/fuzz.yml
+67 −0 .github/workflows/tests.yml
+0 −34 .travis.yml
+50 −3 CHANGES
+60 −87 CMakeLists.txt
+3 −0 CONTRIBUTING.md
+25 −1 LICENSE
+15 −26 README.rst
+9 −0 SECURITY.md
+0 −4 android/jansson_config.h
+2 −0 appveyor.yml
+3 −3 cmake/CodeCoverage.cmake
+0 −111 cmake/Coveralls.cmake
+0 −24 cmake/CoverallsClear.cmake
+0 −380 cmake/CoverallsGenerateGcov.cmake
+4 −6 cmake/jansson_config.h.cmake
+9 −0 cmake/jansson_private_config.h.cmake
+21 −8 configure.ac
+2 −2 doc/Makefile.am
+187 −34 doc/apiref.rst
+1 −1 doc/conf.py
+2 −3 doc/conformance.rst
+20 −11 doc/ext/refcounting.py
+1 −0 doc/github_commits.c
+1 −1 doc/index.rst
+4 −7 doc/threadsafety.rst
+8 −8 doc/upgrading.rst
+4 −4 examples/simple_parse.c
+1 −1 scripts/clang-format
+5 −2 scripts/clang-format-check
+8 −2 src/Makefile.am
+6,265 −0 src/dtoa.c
+39 −18 src/dump.c
+57 −35 src/hashtable.c
+16 −4 src/hashtable.h
+5 −0 src/jansson.def
+36 −3 src/jansson.h
+0 −4 src/jansson_config.h.in
+2 −2 src/jansson_private.h
+2 −2 src/load.c
+1 −1 src/lookup3.h
+5 −4 src/pack_unpack.c
+135 −30 src/strconv.c
+92 −34 src/value.c
+1 −0 test/.gitignore
+17 −122 test/bin/json_process.c
+0 −38 test/ossfuzz/travisoss.sh
+3 −1 test/suites/api/Makefile.am
+1 −1 test/suites/api/check-exports
+228 −0 test/suites/api/test_fixed_size.c
+0 −1 test/suites/encoding-flags/compact-array/env
+0 −1 test/suites/encoding-flags/compact-object/env
+0 −1 test/suites/encoding-flags/ensure-ascii/env
+0 −1 test/suites/encoding-flags/indent-array/env
+0 −1 test/suites/encoding-flags/indent-compact-array/env
+0 −1 test/suites/encoding-flags/indent-compact-object/env
+0 −1 test/suites/encoding-flags/indent-object/env
+0 −1 test/suites/encoding-flags/object/env
+0 −1 test/suites/encoding-flags/preserve-order/env
+0 −1 test/suites/encoding-flags/real-precision/env
+1 −1 test/suites/encoding-flags/real-precision/input
+1 −1 test/suites/encoding-flags/real-precision/output
+2 −12 test/suites/encoding-flags/run
+0 −1 test/suites/encoding-flags/sort-keys/env
+3 −8 test/suites/invalid-unicode/run
+6 −19 test/suites/invalid/run
+1 −0 test/suites/valid/real-exponent-no-dtoa/input
+1 −0 test/suites/valid/real-exponent-no-dtoa/output
+0 −0 test/suites/valid/real-exponent-no-dtoa/skip_if_dtoa
+1 −1 test/suites/valid/real-exponent/input
+1 −1 test/suites/valid/real-exponent/output
+0 −0 test/suites/valid/real-exponent/skip_unless_dtoa
+16 −21 test/suites/valid/run
2 changes: 1 addition & 1 deletion SecurityPkg/DeviceSecurity/SpdmLib/libspdm
Submodule libspdm updated 72 files
+1 −1 .github/workflows/compliance-checks.yml
+1 −1 README.md
+9 −3 doc/api/common_api.md
+47 −0 doc/api/requester_api.md
+3 −3 doc/user_guide.md
+2 −2 include/hal/base.h
+2 −2 include/hal/library/cryptlib/cryptlib_cert.h
+87 −81 include/hal/library/responder/csrlib.h
+60 −1 include/industry_standard/spdm.h
+0 −30 include/internal/libspdm_requester_lib.h
+40 −46 include/library/spdm_common_lib.h
+1 −1 include/library/spdm_lib_config.h
+30 −0 include/library/spdm_requester_lib.h
+9 −9 library/spdm_common_lib/libspdm_com_context_data.c
+41 −23 library/spdm_common_lib/libspdm_com_opaque_data.c
+4 −4 library/spdm_crypt_lib/libspdm_crypt_cert.c
+2 −2 library/spdm_requester_lib/libspdm_req_common.c
+36 −58 library/spdm_requester_lib/libspdm_req_encap_request.c
+11 −8 library/spdm_requester_lib/libspdm_req_get_capabilities.c
+5 −2 library/spdm_requester_lib/libspdm_req_get_certificate.c
+1 −1 library/spdm_requester_lib/libspdm_req_handle_error_response.c
+12 −0 library/spdm_requester_lib/libspdm_req_key_exchange.c
+1 −1 library/spdm_requester_lib/libspdm_req_negotiate_algorithms.c
+11 −0 library/spdm_requester_lib/libspdm_req_psk_exchange.c
+1 −2 library/spdm_requester_lib/libspdm_req_set_key_pair_info.c
+11 −8 library/spdm_responder_lib/libspdm_rsp_capabilities.c
+1 −1 library/spdm_responder_lib/libspdm_rsp_chunk_send_ack.c
+29 −10 library/spdm_responder_lib/libspdm_rsp_csr.c
+53 −77 library/spdm_responder_lib/libspdm_rsp_encap_response.c
+13 −0 library/spdm_responder_lib/libspdm_rsp_key_exchange.c
+13 −0 library/spdm_responder_lib/libspdm_rsp_psk_exchange.c
+18 −16 os_stub/cryptlib_mbedtls/pk/x509.c
+2 −2 os_stub/cryptlib_null/pk/x509.c
+2 −2 os_stub/cryptlib_openssl/pk/x509.c
+1 −1 os_stub/openssllib/openssl
+4 −4 os_stub/openssllib/openssl_gen/openssl/opensslv.h
+9 −7 os_stub/openssllib/openssl_gen/prov/ciphercommon.h
+6 −1 os_stub/openssllib/openssl_gen/prov/ciphercommon_aead.h
+1 −1 os_stub/openssllib/version.txt
+1 −1 os_stub/spdm_cert_verify_callback_sample/spdm_cert_verify_callback_internal.h
+10 −2 os_stub/spdm_device_secret_lib_null/lib.c
+13 −2 os_stub/spdm_device_secret_lib_sample/CMakeLists.txt
+75 −0 os_stub/spdm_device_secret_lib_sample/chal.c
+440 −0 os_stub/spdm_device_secret_lib_sample/csr.c
+98 −0 os_stub/spdm_device_secret_lib_sample/event.c
+456 −0 os_stub/spdm_device_secret_lib_sample/key_pair.c
+0 −2,726 os_stub/spdm_device_secret_lib_sample/lib.c
+792 −0 os_stub/spdm_device_secret_lib_sample/meas.c
+200 −0 os_stub/spdm_device_secret_lib_sample/psk.c
+113 −0 os_stub/spdm_device_secret_lib_sample/read_priv_key_pem.c
+360 −0 os_stub/spdm_device_secret_lib_sample/read_priv_key_raw_data.c
+29 −173 os_stub/spdm_device_secret_lib_sample/read_pub_cert.c
+109 −0 os_stub/spdm_device_secret_lib_sample/read_pub_key_der.c
+204 −0 os_stub/spdm_device_secret_lib_sample/read_special_cert.c
+120 −0 os_stub/spdm_device_secret_lib_sample/set_cert.c
+180 −0 os_stub/spdm_device_secret_lib_sample/sign.c
+44 −11 os_stub/spdm_device_secret_lib_sample/spdm_device_secret_lib_internal.h
+2 −1 unit_test/fuzzing/test_responder/test_spdm_responder_set_key_pair_info_ack/set_key_pair_info_ack.c
+161 −8 unit_test/test_spdm_common/context_data.c
+4 −182 unit_test/test_spdm_requester/error_test/get_capabilities_err.c
+54 −26 unit_test/test_spdm_requester/error_test/key_exchange_err.c
+1 −1 unit_test/test_spdm_requester/get_version.c
+64 −32 unit_test/test_spdm_requester/key_exchange.c
+4 −2 unit_test/test_spdm_requester/psk_exchange.c
+3 −84 unit_test/test_spdm_responder/capabilities.c
+8 −8 unit_test/test_spdm_responder/csr.c
+74 −37 unit_test/test_spdm_responder/key_exchange.c
+5 −5 unit_test/test_spdm_responder/key_pair_info.c
+4 −2 unit_test/test_spdm_responder/psk_exchange.c
+12 −5 unit_test/test_spdm_responder/respond_if_ready.c
+2 −0 unit_test/test_spdm_responder/set_certificate_rsp.c
+3 −3 unit_test/test_spdm_responder/set_key_pair_info_ack.c

0 comments on commit a2782d6

Please sign in to comment.