BoardModulePkg: Added Mock library for BiosIdLib #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivianNK
requested review from
nate-desimone,
SaiChaganty and
ydong10
as code owners
VivianNK
force-pushed
the
vnowkakeane/MockBiosIdLib_v1
branch
from
2cf679c
to
f236c91
Compare
Added a gmock for GoogleTests that pull in BiosIdLib. Cc: Eric Dong <[email protected]> Cc: Liming Gao <[email protected]> Signed-off-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
vnowkakeane/MockBiosIdLib_v1
branch
from
f236c91
to
6bc372d
Compare
|
Requesting review from @nate-desimone @SaiChaganty @ydong10 @lgao4 |
|
@mdkinney Could you please help get reviews for this PR? |
mdkinney
approved these changes
Sep 27, 2024
nate-desimone
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a gmock for GoogleTests that pull in BiosIdLib.
Original PR: https://github.com/microsoft/mu_common_intel_min_platform/pull/261/files