Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Live-Reload: Support uvicorn option "no access log" #176

Conversation

RafaelWO
Copy link

@RafaelWO RafaelWO commented Mar 20, 2023

Implements #177

This MR adds the feature of disabling the uvicorn access log while using live-reload via start-reload.sh. Specifically, the option --no-access-log is passed to to uvicorn if ACCESS_LOG is set to an empty value.

@RafaelWO RafaelWO changed the title ✨ Live-Reload: Support option "no access log" ✨ Live-Reload: Support uvicorn option "no access log" Mar 20, 2023
@RafaelWO
Copy link
Author

Would be great to have this merged - thanks in advance, @tiangolo, for taking a look!

@RafaelWO RafaelWO force-pushed the feature/live-releoad-support-no-access-log branch from 6bf38c3 to 2fc3255 Compare October 9, 2023 15:52
@RafaelWO RafaelWO force-pushed the feature/live-releoad-support-no-access-log branch from 2fc3255 to 54db61e Compare March 17, 2024 15:47
@tiangolo
Copy link
Owner

Thanks for the interest! 🍰

Now that Uvicorn supports managing workers with --workers, including restarting dead ones, there's no need for Gunicorn. That also means that it's much simpler to build a Docker image from scratch now, I updated the docs to explain it.

Because of that, I deprecated this Docker image: https://github.com/tiangolo/uvicorn-gunicorn-docker#-warning-you-probably-dont-need-this-docker-image

Given that, I'll now close this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Aug 25, 2024
@RafaelWO
Copy link
Author

Thanks for the update on this PR and the docs! Happy that it works now without gunicorn 🙂

In general: thanks for developing and maintaining such great open-source projects like FastAPI (plus related tooling) and the awesome documentation! 🎖️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants