Add and use AllowAllCORSMixin #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AllowAllCORSMixin and apply it to legacy profile retrieval API and package version APIs
|
No tests at the moment because the local default applies the Access-Control-Allow-Origin header to every response. |
Remove the AllowAllCORSMixin from every API except LegacyProfileRetrieveApiView, which is unlikely to cause any problems from being opened but also might not work because it redirects to a page that likely isn't open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the Access-Control-Allow-Origin header to * for package version, package retrieval, and legacy profile retrieval APIs. This allows other websites to call them.
The likely result of this is that we'll have websites that call
/api/experimental/package/{namespace}/{name}/hundreds of times while reading a modpack. The Mod Managers don't currently have that problem because they pull that info directly from the package index which is retrieved once.