Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move/copy-to-account #8632

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

mbalduccini
Copy link

Fixes issue 760.
The approach is fairly straightforward:

  • I extended the relevant methods to take the destination account
  • If the destination account is different from the source account, the message is copied over using MessageStore.saveLocalMessage()
  • In case of a move, the source message is deleted
  • Move/copy of threads is supported

It doesn't break any tests as far as I can tell. There are 11 tests that fail on my computer, and they are the same tests that fail in the main branch. Screenshots attached.

Screenshot_20241201_204310_Chrome
Screenshot_20241201_204256_Chrome
Screenshot_20241201_204219_Chrome

@cketti
Copy link
Member

cketti commented Dec 5, 2024

The failing protocol tests might be because the tests were run using an (old?) JDK without an "unlimited cryptography policy". See https://www.java.com/en/configure_crypto.html

The failing tests in QuoteDateFormatterTest are also related to the Java version used to run the tests. #8651 should work around this, though.

In general it's probably best to use the same Java version our GitHub workflow is using. Currrently that's Java 17.

@mbalduccini
Copy link
Author

I switched to Java 17 (I was using 21) and things got a little better. The *ServerSettingsValidatorTest tests no longer fail. The RealImapConnectionTest test still fails as well as the tests in QuoteDateFormatterTest. I am attaching the screenshots.
@cketti I see that there are conflicts on three files. Would you like me to resolve them?

Screenshot_20241205_213356_Chrome
Screenshot_20241205_213326_Chrome
Screenshot_20241205_213303_Chrome

@mbalduccini
Copy link
Author

@cketti I merged your latest changes including #8651. All tests pass now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants