Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of issues related to project resource traversal #73

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ryanjjung
Copy link
Collaborator

@ryanjjung ryanjjung commented Dec 18, 2024

This PR addresses a few main issues.

  1. Can't declare recovery_window_in_days for Secret created by RdsDatabaseGroup #70: When volatile environments using the RDS module are rebuilt, you run into Secrets Manager clobbers. This PR allows you to optionally change the retention period on those secrets to prevent this issue in some environments while allowing the protection of this retention feature in others.
  2. ThunderbirdPulumiProject doesn't flatten resources hidden behind outputs #71: Resources hidden by Pulumi Output objects do not get enumerated properly by monitoring groups.
  3. ThunderbirdComponentResources create namespace pollution in project #72: When ThunderbirdComponentResources register their resources with the project, it can cause namespace pollution.
  4. Updates the AWS provider.

The issues have much more detail about the problems than I've listed here. A good chunk of this is corresponding documentation updates.

@ryanjjung ryanjjung self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant