Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThunderbirdComponentResources create namespace pollution in project #72

Closed
ryanjjung opened this issue Dec 18, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working M: Pulumi Monitoring
Milestone

Comments

@ryanjjung
Copy link
Collaborator

When you run the finish method of a ThunderbirdComponentResource ("TCR", to save my fingers), it blindly adds the resources to the project's resources dict using the name of the resource as a key. If you use a TCR that contains another TCR (like the way the RDS module creates secrets using the Secrets module), then the inner/nested TCR's resources still get added to the top level of project.resources. This breaks the nested structure, pollutes the top level's namespace, and leads to resources being discovered in duplicate during the flattening process later. This doesn't lead to actual problems, as the duplicates are removed by a set typecasting, but it makes debugging anything in the monitoring code very messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working M: Pulumi Monitoring
Projects
None yet
Development

No branches or pull requests

1 participant