Use indices to prevent security group name clobbers

thunderbird · Jan 31, 2025 · 37bf195 · 37bf195
1 parent 326476c
commit 37bf195
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/tb_pulumi/__init__.py b/tb_pulumi/__init__.py
@@ -5,6 +5,7 @@
 # <https://thunderbird.github.io/pulumi/getting-started.html>`_
 import boto3
 import pulumi
+import string
 import yaml
 
 from functools import cached_property

diff --git a/tb_pulumi/network.py b/tb_pulumi/network.py
@@ -319,22 +319,22 @@ def __init__(
         egress_rules = []
 
         ingress_ruledefs = rules['ingress']
-        for rule in ingress_ruledefs:
+        for idx, rule in enumerate(ingress_ruledefs):
             rule.update({'type': 'ingress', 'security_group_id': sg.id})
             ingress_rules.append(
                 aws.ec2.SecurityGroupRule(
-                    f'{name}-ingress-{rule["to_port"]}',
+                    f'{name}-ingress-{idx}',
                     opts=pulumi.ResourceOptions(parent=self, depends_on=[sg]),
                     **rule,
                 )
             )
 
         egress_ruledefs = rules['egress']
-        for rule in egress_ruledefs:
+        for idx, rule in enumerate(egress_ruledefs):
             rule.update({'type': 'egress', 'security_group_id': sg.id})
             egress_rules.append(
                 aws.ec2.SecurityGroupRule(
-                    f'{name}-egress-{rule["to_port"]}',
+                    f'{name}-egress-{idx}',
                     opts=pulumi.ResourceOptions(parent=self, depends_on=[sg]),
                     **rule,
                 )