Fix limited booking options bug #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another fix to this issue would be not converting the start_time and end_time to utc on the frontend, however also gets tricky because every other date is utc. Just wanted to mention it was something I thought about 😄 |
|
I will test this thoroughly on Monday and report back. And no reason to say sorry for replacing my ugly function with something way more elegant 👍🏻 Yes we could send dates with tz information to the backend, but I decided to base everything on UTC for keeping things simple and no headaches while thinking about where to use UTC and where TZ dates... |
devmount
approved these changes
Jan 15, 2024
|
Thanks! |
devmount
added a commit
that referenced
this pull request
Jan 15, 2024
* Fix available_slots_from_schedule to account for end_time being in the next day. * Add tzinfo as a dependency for ZoneInfo * 📜 update comments --------- Co-authored-by: Andreas Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
We were converting the start and end time to utc, which caused us North Americans to have a 9-5 translate to something like 17 - 1 after utc conversion.
I ended up re-writing the function (sorry 😄).
Basically we loop between the
earliest_bookingand the end time (eitherschedule_endorfarthest_booking), check if it's a valid day within the schedule's weekday selection, and finally build that days slots between thestart_timeandend_time(accounting for the timezone conversion issue.)There's a few problems with this (and I believe also the previous code but correct me if I'm wrong!) where the
earliest_bookingtime doesn't account for bookable days, just any day that comes up. So if I only allow people to book me on weekdays, and I have my earliest booking set to 24 hours, then people can still book me on Monday.That ux is kind of weird too, I'm not sure if I fully remember how that should work. Maybe a thing to discuss at the next meeting 😄