Vite #207
Merged
Vite #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
approved these changes
Dec 11, 2023
frontend/src/router.js
Outdated
| @@ -98,7 +98,7 @@ const routes = [ | |||
|
|
|||
| // create router object to export | |||
| const router = createRouter({ | |||
| history: createWebHistory(process.env.BASE_URL), | |||
| history: createWebHistory(''), | |||
There was a problem hiding this comment.
Why don't we use import.meta.env.BASE_URL here?
There was a problem hiding this comment.
Ah right, I thought this was a broken env originally. I've reverted it, thanks for pointing it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Trying to get out all the task related things now that MVP is done. I wish I had done this sooner as the dev server is about 10,000,000x faster than webpack.
Needs a good test though, I'm not sure eslint is working correctly. It took me a while to fix the path resolving, but maybe it's the consequences of me forgetting to run eslint at all. 😅
I fixed up the envs too, and blanked out one case in the router where it was appending the url twice. (It was broken on the webpack build because all envs there required
VUE_APP_and it did not originally have that.)