Upgrade warning to error, and fix dict.get() for fxa webhooks.

thunderbird · Jan 8, 2024 · ae58fd9 · ae58fd9
1 parent fbe55d7
commit ae58fd9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/backend/src/appointment/dependencies/fxa.py b/backend/src/appointment/dependencies/fxa.py
@@ -51,6 +51,6 @@ def get_webhook_auth(request: Request, fxa_client: FxaClient = Depends(get_fxa_c
 
     # Final verification
     if decoded_jwt.get('iss') != fxa_client.config.issuer:
-        logging.warning(f"Issuer is not valid: ({decoded_jwt.get('iss')}) vs ({fxa_client.config.issuer})")
+        logging.error(f"Issuer is not valid: ({decoded_jwt.get('iss')}) vs ({fxa_client.config.issuer})")
 
     return decoded_jwt
diff --git a/backend/src/appointment/routes/webhooks.py b/backend/src/appointment/routes/webhooks.py
@@ -15,7 +15,7 @@
 def fxa_process(
     request: Request,
     db: Session = Depends(get_db),
-    decoded_token = Depends(get_webhook_auth),
+    decoded_token: dict = Depends(get_webhook_auth),
     fxa_client: FxaClient = Depends(get_fxa_client)
 ):
     """Main for webhooks regarding fxa"""
@@ -27,7 +27,7 @@ def fxa_process(
 
     fxa_client.setup(subscriber.id, subscriber.get_external_connection(models.ExternalConnectionType.fxa).token)
 
-    for event, event_data in decoded_token.get('events', default={}).items():
+    for event, event_data in decoded_token.get('events', {}).items():
         match event:
             case 'https://schemas.accounts.firefox.com/event/password-change':
                 # We also get `changeTime` in event_data, but let's just log them out.