Release v1.30.0 #569
Merged
Release v1.30.0 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 68.09% 68.00% -0.10%
==========================================
Files 139 140 +1
Lines 23838 23872 +34
==========================================
Hits 16233 16233
- Misses 4544 4578 +34
Partials 3061 3061
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Apr 6, 2023
PR (#554) introduced an optimization for the String() method of typedefs. There are two issues with this change: - Since the "fmt" import was global, if fmt.Sprint was dropped from the typedef code generation the import would be unused. - Using compiled.RootTypeSpec for isStringType results in situations where a non-string type is return from a String() function resulting in uncompilable code. func(v StringReDef) String() string { x := (stringdef.StringDef)(v) return x } This happens when a type is a typedef of another string typedef. I've added generated code cases to demonstrate and verify the corrected behavior.
This commit serves as the v1.30.0 release. The commit merged in (#567) was never tagged and released as v1.30.0 as a bug was found in that commit before we tagged a release for it. This commit contains the fix for the aforementioned bug. This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
r-hang
force-pushed
the
rhang/release-take-2
branch
from
9367618 to
6f40bfe
Compare
r-hang
added a commit
that referenced
this pull request
Apr 6, 2023
This commit serves as the v1.30.0 release. The commit merged in (#567) was never tagged and released as v1.30.0 as a bug was found in that commit before we tagged a release for it. This commit contains the fix for the aforementioned bug. This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
r-hang
added a commit
that referenced
this pull request
Apr 6, 2023
This commit serves as the v1.30.0 release. The commit merged in (#567) was never tagged and released as v1.30.0 as a bug was found in that commit before we tagged a release for it. This commit contains the fix for the aforementioned bug. This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit serves as the v1.30.0 release.
The commit merged in (#567) was never tagged and released as v1.30.0 as
a bug was found in that commit before we officially cut a release for it. This commit contains a fix for that bug.
This release contains the following changes: