gen/enum: Implement encoding.TextUnmarshaler #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes generated code for enums to implement the encoding.TextUnmarshaler interface. This exposes a simple API to users for reading enums by name in addition to integrating better with other encoding libraries.
prashantv
approved these changes
May 8, 2017
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ v1.3.0 (unreleased) | |||
|
|
|||
| - Plugins: Added support for overriding the communication channels used by | |||
| plugins. | |||
| - Enums now implement `encoding.TextUnmarshaler`. | |||
There was a problem hiding this comment.
maybe a small note for what this means?
bombela
approved these changes
May 8, 2017
|
Looks good to me, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes generated code for enums to implement the
encoding.TextUnmarshaler interface. This exposes a simple API to users
for reading enums by name in addition to integrating better with
other encoding libraries.
(This was pulled from #308. Thanks @recht!)