-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This release contains the following changes: - AddTemplate template option. - thriftbreak: support for changed types, new files, and optional JSON output. - String() performance improvements for string type definitions.
- Loading branch information
Showing
214 changed files
with
2,718 additions
and
1,725 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| // Copyright (c) 2023 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "errors" | ||
| "flag" | ||
| "fmt" | ||
| "io" | ||
| "log" | ||
| "os" | ||
|
|
||
| "go.uber.org/thriftrw/internal/compare" | ||
| "go.uber.org/thriftrw/internal/git" | ||
| ) | ||
|
|
||
| func main() { | ||
| if err := run(os.Args[1:]); err != nil && !errors.Is(err, flag.ErrHelp) { | ||
| log.Fatalf("%+v", err) | ||
| } | ||
| } | ||
|
|
||
| // readableOutput prints every lint error on a separate line. | ||
| func readableOutput(w io.Writer) func(compare.Diagnostic) error { | ||
| return func(diagnostic compare.Diagnostic) error { | ||
| if _, err := fmt.Fprintln(w, &diagnostic); err != nil { | ||
| return fmt.Errorf("failed to output a lint error: %v", err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // jsonOutput prints out every lint error in JSON format. | ||
| func jsonOutput(w io.Writer) func(compare.Diagnostic) error { | ||
| enc := json.NewEncoder(w) | ||
|
|
||
| return func(diagnostic compare.Diagnostic) error { | ||
| // Encode adds a trailing newline. | ||
| if err := enc.Encode(diagnostic); err != nil { | ||
| return fmt.Errorf("encode as JSON: %v", err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| } | ||
|
|
||
| func run(args []string) error { | ||
| flag := flag.NewFlagSet("thriftbreak", flag.ContinueOnError) | ||
| gitRepo := flag.String("C", "", | ||
| "location of git repository. Defaults to current directory.") | ||
| jsonOut := flag.Bool("json", false, | ||
| "output as a list of newline-delimited JSON objects with the following fields: FilePath and Message") | ||
| if err := flag.Parse(args); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if *gitRepo == "" { | ||
| cwd, err := os.Getwd() | ||
| if err != nil { | ||
| return fmt.Errorf("cannot determine current directory: %v", err) | ||
| } | ||
| *gitRepo = cwd | ||
| } | ||
|
|
||
| pass, err := git.Compare(*gitRepo) | ||
| // Errors in compiling phase, but not in backwards compatibility. | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var write func(compare.Diagnostic) error | ||
| if *jsonOut { | ||
| write = jsonOutput(os.Stdout) | ||
| } else { | ||
| write = readableOutput(os.Stdout) | ||
| } | ||
| lints := pass.Lints() | ||
| for _, l := range lints { | ||
| if err := write(l); err != nil { | ||
| return fmt.Errorf("failed to output error: %v", err) | ||
| } | ||
| } | ||
|
|
||
| if len(lints) > 0 { | ||
| return fmt.Errorf("found %d issues", len(lints)) | ||
| } | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.