Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init location indexer #1260

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

init location indexer #1260

wants to merge 2 commits into from

Conversation

Omarabdul3ziz
Copy link
Contributor

  • remove the region column and triggers from the cache table
  • add the indexer with the schema changes and generator
  • make the removeDuplicates function generic to be used with all indexers
  • add location info indexer #1248

Blocked

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@Omarabdul3ziz
init location indexer:
0c0246a 
- remove the region column and triggers from the cache table
- add the indexer with the schema changes and generator
- make the removeDuplicates function generic to be used with all indexers
@Omarabdul3ziz
remove unused country codes
3a340ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioBassem MarioBassem Awaiting requested review from MarioBassem MarioBassem will be requested when the pull request is marked ready for review MarioBassem is a code owner

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda will be requested when the pull request is marked ready for review ashraffouda is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan will be requested when the pull request is marked ready for review rawdaGastan is a code owner

@AbdelrahmanElawady AbdelrahmanElawady Awaiting requested review from AbdelrahmanElawady AbdelrahmanElawady will be requested when the pull request is marked ready for review AbdelrahmanElawady is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader will be requested when the pull request is marked ready for review xmonader is a code owner

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk sameh-farouk will be requested when the pull request is marked ready for review sameh-farouk is a code owner

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara Eslam-Nawara will be requested when the pull request is marked ready for review Eslam-Nawara is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Omarabdul3ziz