Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fn/func in nodes #245

Merged
merged 4 commits into from
Sep 1, 2022
Merged

feat: fn/func in nodes #245

merged 4 commits into from
Sep 1, 2022

Conversation

miko3k
Copy link
Contributor

@miko3k miko3k commented Aug 21, 2022

Why

#239

What

please note that this PR also changes package.json a bit to enable both yarn test and yarn test-all to work

  • bringing relevant typing to sync with r144
  • general improvements of FunctionNode/FunctionCallNode with generics modelling the required parameter
    • note that func returning ShaderNode was a hack, in reality it was something ShaderNode-like (having call-method accepting Swizzable). FunctionNode as the generic parameter was plainly wrong.
  • automatically generate proxified versions of parameters of FunctionNode using mapped type Fn
  • fn/func take same generic argument as FunctionNode
  • MakeObjectOption was renamed to Proxied, I added some comments although I am still not too happy
  • relevant tests
  • newly defined types:
    • FunctionNodeArguments, pretty self-explanatory
    • Fn converts FunctionNodeArguments into Proxied version of it

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@joshuaellis joshuaellis merged commit 78f7659 into three-types:dev Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants