Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#239
What
please note that this PR also changes
package.json
a bit to enable bothyarn test
andyarn test-all
to workFunctionNode
/FunctionCallNode
with generics modelling the required parameterfunc
returningShaderNode
was a hack, in reality it was somethingShaderNode
-like (havingcall
-method acceptingSwizzable
).FunctionNode
as the generic parameter was plainly wrong.FunctionNode
using mapped typeFn
fn
/func
take same generic argument asFunctionNode
MakeObjectOption
was renamed toProxied
, I added some comments although I am still not too happyFunctionNodeArguments
, pretty self-explanatoryFn
convertsFunctionNodeArguments
intoProxied
version of itChecklist
master
, next goesdev
)