Update deps #218
Merged
Update deps #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The nightly CI failure is due to rust-lang/rust#57484 |
kvark
approved these changes
Jan 10, 2019
|
CI issue is resolved now |
|
Bors r+
… On Jan 11, 2019, at 01:43, Lucas Kent ***@***.***> wrote:
CI issue is resolved now
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
Jan 11, 2019
218: Update deps r=kvark a=rukai * .gitignore was changed to handle both a regular target folder and a symlinked target folder * All outdated dependencies are now up to date https://deps.rs/repo/github/three-rs/three * This is the last issue blocking #208 ## Breaking changes * glutin is updated to 0.19 * removed `window::Window::set_cursor_state` because winit now exposes this as multiple boolean setters. Users can access them via the raw glutin window. If someone wants this functionality to be wrapped via three-rs then they can implement it themselves. * `fn window::Builder::dimensions` now takes f64 representing logical dimensions instead of physical dimensions Co-authored-by: Rukai <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
window::Window::set_cursor_statebecause winit now exposes this as multiple boolean setters. Users can access them via the raw glutin window. If someone wants this functionality to be wrapped via three-rs then they can implement it themselves.fn window::Builder::dimensionsnow takes f64 representing logical dimensions instead of physical dimensions