Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'Dropped frames' log level back down from WARNING to DEBUG #490

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

whitingjp
Copy link
Contributor

I don't know if this is necessarily still true with the newer move controllers, but with the older ones I have there is now a very large amount of 'dropped frames' log messages all the time with controllers connected.

Frames were always getting 'dropped' in this way before, but in c9ee3b0 "New logging macros" this particular log message changed from DEBUG, to WARNING, and is therefore now displayed in a default build of the api

As far as I can tell, the 'frame drops' were not, and are not causing any actual problems using the api, so it seems to me that either DEBUG feels like a more appropriate log level to use, or else it would make sense to do something else to reduce the unhelpfully large amount of spam.

(if this isn't the appropriate solution, I'd be happy to spend a bit of time working on a better one)

…ed to be this way, and while sounding scary, dropped frames do not seem to be a problem in practice
@nitsch
Copy link
Collaborator

nitsch commented Apr 21, 2024

I don't know where @thp was going with this, so he should take a quick look.

While I agree with your assessment, it would of course be much better to get to the bottom of these frame drops and possibly fix that. So if you would be willing to look into this that'd be awesome!

@whitingjp
Copy link
Contributor Author

Yeah, fixing the cause of the warnings would be better, assuming that is even feasible in the first place, I don't know if it is or not! I did already have a bit of a look, and did establish that whether using my api-driving code (i.e. JS Joust), or the psmoveapi examples these 'drops' have been occurring without impact for a long time. But I wasn't really able to get further into work out why they were a thing, or whether they ever needed reporting in the first place..

I don't know very much about how the internals of psmoveapi work, and even less about the lower levels of the stack. And I'm pretty busy with a new job, so I don't anticipate having much time for deeper diving in that direction in the near future!

@whitingjp
Copy link
Contributor Author

I more meant "if there's a better way of making these warnings quieter I'll happily do that instead", which is something I could still plausibly do, than "I can look into why this is a thing in the first place" which looks like it would require a lot more deep diving than I'm equipped to do at the moment!

Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put it back to debug for now.

@thp thp merged commit bf4460f into thp:master Apr 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants