Changed 'Dropped frames' log level back down from WARNING to DEBUG #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is necessarily still true with the newer move controllers, but with the older ones I have there is now a very large amount of 'dropped frames' log messages all the time with controllers connected.
Frames were always getting 'dropped' in this way before, but in c9ee3b0 "New logging macros" this particular log message changed from DEBUG, to WARNING, and is therefore now displayed in a default build of the api
As far as I can tell, the 'frame drops' were not, and are not causing any actual problems using the api, so it seems to me that either DEBUG feels like a more appropriate log level to use, or else it would make sense to do something else to reduce the unhelpfully large amount of spam.
(if this isn't the appropriate solution, I'd be happy to spend a bit of time working on a better one)