fix: alert rule and tests association #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brumarqu-te
force-pushed
the
fix_alert_rule_tests
branch
from
94da99b to
b566f8d
Compare
|
closing in favour of #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #158
Changes the alert rule
test_idsschema attribute to be computed so that it is not considered in the TF plan.Also, since the alert rule returns a field
testswhen getting by id and receives a fieldtestIdswhen updating the alert rule, had to implement a map from the GenericTest to get only the testId.One drawback of this approach (not a huge one IMO) is that the state may not always be accurate. This is because a test <-> alert rules association can be changed from the test perspective and not get reflected on the alert rule perspective. Anyways, it will eventually update the state when the next alert rule update is performed.
The compilation and test failure is because the following PR needs to be merged and released and then updated the version here: thousandeyes/thousandeyes-sdk-go#122