Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade habitat-sim to 0.3.1 and Python to 3.9 #191

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codingkoi
Copy link
Contributor

Newer versions of the habitat-sim library require Python 3.9 so this upgrades to the newest version that doesn't seem to break everything.

Python 3.8 is past end of life, so this also gets us on a supported version.

@codingkoi
Copy link
Contributor Author

This is going to need additional work, as at least two of the tests are failing when I run them locally, but I lack the knowledge to know how they should be fixed or if they're serious breaks.

These are the results I get locally:

FAILED tests/unit/evidence_lm_test.py::EvidenceLMTest::test_symmetry_recognition - AssertionError: Lists differ: [-180.0, 0.0, 180.0] != [180.0, 0.0, 180.0]
FAILED tests/unit/evidence_lm_test.py::EvidenceLMTest::test_two_lm_heterarchy_experiment - AssertionError: 'no_match' != 'correct'

@codingkoi
Copy link
Contributor Author

For context, this is an issue that @tristanls suggested as a place to start helping out.

@codingkoi codingkoi changed the title Upgrade habitat-sim to 0.3.2 and Python to 3.9 Upgrade habitat-sim to 0.3.1 and Python to 3.9 Feb 25, 2025
@tristanls
Copy link
Contributor

tristanls commented Feb 25, 2025

Thank you for opening the draft pull request @codingkoi. An upgrade of sim and Python will be a helpful addition.

I noticed that the test workers crashed. Crashed test workers indicate that likely it is HabitatSim crashing. You will find some troubleshooting hints here Test failure: worker crashes during setup · Issue #86 · thousandbrainsproject/tbp.monty · GitHub

@codingkoi codingkoi force-pushed the upgrade-habitatsim branch 2 times, most recently from 48f40be to ae47d52 Compare February 26, 2025 17:52
@codingkoi
Copy link
Contributor Author

Per discussions with @tristanls, I added a small test to see if the observations in the HabitatSim environment match when run in GH actions vs my local Linux machine, since I'm getting vastly different test results between the two test environments.

In an effort to get to the bottom of the differences between various OSs
and environments when running the tests, I'm adding a test to try to
verify that the observations that the HabitatSim is getting match across
test environments.

At the moment, I'm just planning to manually test these, comparing my
local Linux environment with the GitHub Actions environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants