Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit this page #175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Edit this page #175

wants to merge 5 commits into from

Conversation

codeallthethingz
Copy link
Contributor

@codeallthethingz codeallthethingz commented Feb 8, 2025 •
edited
Loading

@codeallthethingz codeallthethingz marked this pull request as ready for review February 8, 2025 21:55
@thousandbrainsproject thousandbrainsproject deleted a comment from github-actions bot Feb 9, 2025
@codeallthethingz codeallthethingz added documentation Improvements or additions to documentation triaged This issue or pull request was triaged labels Feb 9, 2025
vkakerbeck
vkakerbeck approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@vkakerbeck vkakerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, this will be a great feature to have!

docs/snippets/edit-this-page.md

<a class="contribution-button" style="text-decoration:none" href="!!LINK!!" target="_blank">
<img src="https://raw.githubusercontent.com/primer/octicons/main/icons/git-pull-request-16.svg" width="16" height="16" style="display: inline-block; vertical-align: middle;" alt="Pull request icon">
<span style="margin-left: 5px;">Make a Contribution</span></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should just say "Contribute." It seems more concise, but that's just personal preference.

tristanls
tristanls approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@tristanls tristanls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (non-blocking): insert_markdown_snippet does not sanitize input.

I didn't notice it in the snippet pull request, but it became more apparent in this one. It looks to me like insert_markdown_snippet needs to sanitize whatever it puts in the body. Either that or the body needs to be sanitized before the doc is created.

I'm making this non-blocking in case you want to address it in a different pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

📚 Documentation Preview

✅ A preview of the documentation changes in this PR is available for maintainers at:
https://thousandbrainsproject.readme.io/v0.0-codeallthethingz-edit-this-page

Last updated: 2025-02-11 18:44 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanls tristanls tristanls approved these changes

@vkakerbeck vkakerbeck vkakerbeck approved these changes

Assignees

@tristanls tristanls

@vkakerbeck vkakerbeck

Labels
documentation Improvements or additions to documentation triaged This issue or pull request was triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeallthethingz @tristanls @vkakerbeck