fixed 0 frames problem in intro, and rounding up when doing conversio…

…n of FPS to milliseconds - MR
thoughtworksarts · Mar 22, 2018 · 6802928 · 6802928
1 parent 3b1f25d
commit 6802928
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/components/intro.js b/app/components/intro.js
@@ -43,7 +43,7 @@ export default class Intro extends React.Component {
 				<div id="intro">
 					<form onSubmit={this.handleIntroSubmit}>
 						<label>How many levels? &nbsp;</label><input type="number" min={1} max={20} name="numLevels" value={this.state.numLevels} placeholder={this.state.numLevels} onChange={this.handleInputChange}/><br/>
-						<label>How many frames per second is your video? &nbsp; </label><input type="number" min={0} max={100} name="numFrames" value={this.state.numFrames} placeholder={this.state.numFrames} onChange={this.handleInputChange}/><br/>
+						<label>How many frames per second is your video? &nbsp; </label><input type="number" min={1} max={100} name="numFrames" value={this.state.numFrames} placeholder={this.state.numFrames} onChange={this.handleInputChange}/><br/>
 						<Button bsStyle="primary" type="submit">Start Configuring!</Button>
 					</form>
 				</div>

diff --git a/app/utilities/exportHelperFunctions.js b/app/utilities/exportHelperFunctions.js
@@ -2,7 +2,7 @@ const convertToMilliseconds = (value, numFrames) => {
     const valuesArray = value.split(".");
     const numMillisecondsPerFrame = 1000/Number(numFrames);
     const frame = Number(valuesArray[1])-1; // convert to a 0-indexed format
-    const milliseconds = ("000" + Math.round(frame*numMillisecondsPerFrame)).slice(-3);
+    const milliseconds = ("000" + Math.ceil(frame*numMillisecondsPerFrame)).slice(-3);
 
     return valuesArray[0] + "." + milliseconds;
 }