Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alphabetically order blips #330

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Jul 8, 2023

Case-insensitive ordering of blips by name within their quadrant and ring

@setchy
Copy link
Contributor Author

setchy commented Sep 7, 2023

@marisahoenig @devansh-sharma-tw - any feedback re: this PR?

@marisahoenig
Copy link
Member

Hey @setchy — from what I've seen, the blips are already numbered alphabetically. Can you confirm if this is still needed?

@setchy
Copy link
Contributor Author

setchy commented Apr 10, 2024

Hey @setchy — from what I've seen, the blips are already numbered alphabetically. Can you confirm if this is still needed?

Hi @marisahoenig - you are correct, it does order alphabetically, however, it isn't case-insensitive, unlike that of thoughtworks.com/radar based on side-by-side comparisons.

The key change in this PR is converting the blip name to lowercase during the ordering process

@setchy setchy requested review from will-amaral and a team as code owners April 11, 2024 18:46
@setchy
Copy link
Contributor Author

setchy commented May 9, 2024

@will-amaral - appreciate your thoughts on this PR

@setchy
Copy link
Contributor Author

setchy commented May 28, 2024

@shiviraj - appreciate your feedback/review on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants