Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update instructions for generating a new app #1223

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Commits on Aug 16, 2024

  1. README: Update instructions for generating a new app

    Closes #1221
    
    The [release of Rails 7.2.0][rails_7_2] introduced its [own linting
    mechanism][rails-lint].
    
    Unfortunately, this creates a conflict with [our linting
    mechanism][suspenders-lint].
    
    This is only relevant when running `rails new` with our [application
    template][].
    
    In order to fix this, we simply require the caller pass
    `--skip_rubocop`.
    
    A future commit could explore re-introducing the system executable to
    account for our required options, but for now, this fixes the issue.
    
    [rails_7_2]: https://guides.rubyonrails.org/v7.2/7_2_release_notes.html
    [rails-lint]: https://guides.rubyonrails.org/v7.2/7_2_release_notes.html#add-omakase-rubocop-rules-by-default
    [suspenders-lint]: https://github.com/thoughtbot/suspenders/blob/main/FEATURES.md#linting
    [application template]: https://github.com/thoughtbot/suspenders/blob/main/lib/install/web.rb
    stevepolitodesign committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    23d3354 View commit details
    Browse the repository at this point in the history