Allow specifying the type of params #108
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational
Like #94 with
Date
, I faced a problem with some "complex" types I wanted to pass as params.The Pull Request allows one to specify the expected type of
params
(initiallyDeepPartial<T>
) so we can easily use types such as luxon's DateTime without altering the library (unlike #94).Note: For backward compatibility,
P
(type of params) was of course defaulted toDeepPartial<T>
.Example
Before
The library used to prevent this:
params#createdAt
was aDeepPartial<DateTime>
, which prevent the patternconst createdAt = createdAt ?? DateTime.fromJSDate(faker.date.soon());
After