Only reload if cache_classes is disabled and reload_classes_only_on_change #533
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange disabled https://guides.rubyonrails.org/configuring.html#config-reload-classes-only-on-change states: >>> 3.2.30 config.reload_classes_only_on_change Enables or disables reloading of classes only when tracked files change. By default tracks everything on autoload paths and is set to true. If config.cache_classes is true, this option is ignored. >>> It was surprising to us that even though `cache_classes` were set to true that factory_bot_rails still instantiated file watchers.
stanhu
force-pushed
the
sh-stop-reloading-classes
branch
from
5d2fc14 to
ce3d79e
Compare
stanhu
changed the title
|
Hmm, this is not so easy to test directly because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://guides.rubyonrails.org/configuring.html#config-reload-classes-only-on-change states:
3.2.30 config.reload_classes_only_on_change
Enables or disables reloading of classes only when tracked files change. By default tracks everything on autoload paths and is set to true. If config.cache_classes is true, this option is ignored.
It was surprising to us that even though
cache_classeswere set to true that factory_bot_rails still instantiated file watchers.