Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show GitHub projects on new About tab, add Home screen content #53

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

stevehanson
Copy link

@stevehanson stevehanson commented Aug 22, 2024

  • Adds content to the Home Screen
  • Adds an "About" screen that lists open source projects
Before After New About
Screenshot 2024-08-22 at 4 53 50 PM Screenshot 2024-08-22 at 4 52 48 PM Screenshot 2024-08-22 at 4 55 06 PM
demo.mov

Note: this loads projects from an app hosted on my Vercel account. Todo, move to thoughtbot-owned.


# now run without the dry-run flag:
> rsync -avp . ../../templates/boilerplate/ --exclude node_modules --exclude .cache --exclude .expo --exclude .vscode --exclude assets --exclude .git --exclude .gitignore
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of automating this process as part of a command? Are there parts of the rsync process that would be reliant on the specifics of each new feature?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I added a script bin/sync-from-app.js which syncs files back from the app into Belt, and I updated the CONTRIBUTING.md doc.

@@ -30,6 +30,7 @@
"msw": "^2.2.14",
"react": "18.2.0",
"react-native": "0.74.5",
"react-native-keyboard-aware-scroll-view": "^0.9.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding react-native-keyboard-aware-scroll-view do we still need the existing react-native-keyboard-aware-scrollview? (scroll-view vs scrollview)

Copy link
Author

@stevehanson stevehanson Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! scroll-view is actually what we want. It must have been a mistake to originally add scrollview. I removed scrollview.

@stevehanson stevehanson force-pushed the new-content branch 2 times, most recently from 2f2a3bc to d5c7447 Compare August 22, 2024 22:05
@stevehanson
Copy link
Author

I chatted with Diego at the end of his day. Since his blog post announcing Belt will go out tomorrow, I will go ahead and merge this and cut a build, so we have these updates in place.

@stevehanson stevehanson merged commit e0f1cfa into main Aug 22, 2024
2 checks passed
@stevehanson stevehanson deleted the new-content branch August 22, 2024 22:11
@stevehanson stevehanson changed the title Show GitHub projects on new About tab Show GitHub projects on new About tab, add Home screen content Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants