Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent npm from ignoring .gitignore #36

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ npm-debug.log
ios/
android/

# don't commit this since is auto-generated when packing or publishing
templates/boilerplate/.npmignore

# ignore these in case the app was run directly from templates/boilerplate
# also add these to bin/prepack.js
/templates/boilerplate/bun.lockb
/templates/boilerplate/yarn.lock
/templates/boilerplate/package-lock.json
Expand Down
37 changes: 37 additions & 0 deletions bin/prepack.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#!/usr/bin/env node

import fs from 'fs-extra';

// npm will not package the .gitignore file in templates/boilerplate/.gitignore
// by default. The solution is to create a .npmignore file that npm will use
// instead of the .gitignore file, and tell it to include the .gitignore file.
// We want everything in the .gitignore file to also be in the .npmignore file
// so we can ensure we don't accidentally package files that should be ignored.
// This script is run prior to packaging the library for npm (see package.json
// "prepack" script) and generates the .npmignore from the .gitignore to ensure
// they are always in sync.
//
// Also include any lock files or other files that shouldn't be included in the
// .gitignore file but that we want to ensure are not packaged to npm. These
// files can also be added to the root gitignore file to ensure they're also
// excluded from git
function copyGitIgnoreToNpmIgnore() {
const gitIgnore = './templates/boilerplate/.gitignore';
const npmIgnore = './templates/boilerplate/.npmignore';

fs.copySync(gitIgnore, npmIgnore);

fs.appendFileSync(
npmIgnore,
`
// # Prevent NPM from ignoring the .gitignore file
!.gitignore
bun.lockb
yarn.lock
package-lock.json
pnpm-lock.yaml
`,
);
}

copyGitIgnoreToNpmIgnore();
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "create-belt-app",
"author": "thoughtbot, Inc.",
"license": "MIT",
"version": "0.3.0",
"version": "0.3.1",
"description": "React Native Expo project starter and generator CLI",
"type": "module",
"exports": "./dist/index.js",
Expand All @@ -19,6 +19,7 @@
"package.json"
],
"scripts": {
"prepack": "node ./bin/prepack.js",
"build": "tsup",
"dev": "tsup --watch",
"clean": "rm -rf dist node_modules",
Expand Down
2 changes: 2 additions & 0 deletions templates/boilerplate/.gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Learn more https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files

## ATTENTION: Files ignored here must be mirrored in the sibling .npmignore file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a problem with other package managers such as yarn or bun? Is it because we hit this problem only while using npx?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakeshpetit this is an issue with the npm package registry when packaging the library and publishing to npm. Yarn and bun don’t have package registries, so are not relevant here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file gets copied into new apps generated by Belt, will this comment cause confusion?


# dependencies
node_modules/

Expand Down
Loading