-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent npm from ignoring .gitignore #36
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/usr/bin/env node | ||
|
||
import fs from 'fs-extra'; | ||
|
||
// npm will not package the .gitignore file in templates/boilerplate/.gitignore | ||
// by default. The solution is to create a .npmignore file that npm will use | ||
// instead of the .gitignore file, and tell it to include the .gitignore file. | ||
// We want everything in the .gitignore file to also be in the .npmignore file | ||
// so we can ensure we don't accidentally package files that should be ignored. | ||
// This script is run prior to packaging the library for npm (see package.json | ||
// "prepack" script) and generates the .npmignore from the .gitignore to ensure | ||
// they are always in sync. | ||
// | ||
// Also include any lock files or other files that shouldn't be included in the | ||
// .gitignore file but that we want to ensure are not packaged to npm. These | ||
// files can also be added to the root gitignore file to ensure they're also | ||
// excluded from git | ||
function copyGitIgnoreToNpmIgnore() { | ||
const gitIgnore = './templates/boilerplate/.gitignore'; | ||
const npmIgnore = './templates/boilerplate/.npmignore'; | ||
|
||
fs.copySync(gitIgnore, npmIgnore); | ||
|
||
fs.appendFileSync( | ||
npmIgnore, | ||
` | ||
// # Prevent NPM from ignoring the .gitignore file | ||
!.gitignore | ||
bun.lockb | ||
yarn.lock | ||
package-lock.json | ||
pnpm-lock.yaml | ||
`, | ||
); | ||
} | ||
|
||
copyGitIgnoreToNpmIgnore(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not a problem with other package managers such as
yarn
orbun
? Is it because we hit this problem only while usingnpx
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakeshpetit this is an issue with the npm package registry when packaging the library and publishing to npm. Yarn and bun don’t have package registries, so are not relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file gets copied into new apps generated by Belt, will this comment cause confusion?