Add Push Notifications command #34

codeofdiego · 2024-02-27T18:50:51Z

This PR adds the ability to set up Push Notifications as an independent command to be used after the user executes the initial create setup. It performs the following changes in the project:

Add React Native Firebase and messaging dependencies
Copies a template directory with a new useNotifications hook and requestNotificationPermission utility
Updates the App.tsx file to import and run the hook
Adds the native folders to the .gitignore file
Adds required config object to the app.json file.

To achieve some of these changes 3 new utility functions were added:

readAppJson - returns the app.json file as a parsed json object
addAppJsonConfig - deep merges a provided ExpoConfig config with the existing content of the app.json file
injectHooks - takes a list of hooks and their imports, and injects them in the App.tsx file

Additionally, this PR includes new rules for import organizations in the .eslintrc.js.eta template, this was necessary to give us the ability to reorganize imports when we inject code/imports in existing files. This will be a repeating scenario as we add more commands to Betl.

Preview

Collapsed	Expanded

stevehanson

This is looking great! Thank you for working on this 🙌 I'm still going through this but wanted to get a first round of feedback back.

src/commands/eslint.ts

src/commands/notifications.ts

src/types.ts

src/util/addAppJsonConfig.ts

src/util/injectHooks.ts

codeofdiego · 2024-03-07T17:01:08Z

This should be good for review again.

stevehanson

Thanks for all of this great work! It seems like it's getting close!

src/commands/notifications.ts

src/cli.ts

src/commands/__tests__/notifications.test.ts

src/util/injectHooks.ts

templates/eslint/.eslintrc.js.eta

templates/notifications/src/hooks/useNotifications.ts

codeofdiego · 2024-03-18T12:41:50Z

Hi @stevehanson, please let me know if there's anything left on this PR.

This includes the addNotifications command itself, an app.config.ts file to include the google service files without changing the contents of app.json directly and a requestNotificationPermission utility to be added separately

… and their imports into the App.tsx file

This will be necessary when dynamically adding imports to ensure the right order is kept.

This will help run linter after performing changes to app files

…port

…ependency, this was causing tests to fail

We thought this was a bit too heavy handed and might interfere with projects that already have native changes being tracked

… the project

…or handling to commit actions

Co-authored-by: Stephen Hanson <[email protected]>

…import order in the boilerplate

We decided to discuss it further as part of the eslint-config project instead. For now organizing impots does not affect belt functionality.

Removed the getProjectDir mock as it should be already covered by the fs-extra mock in __mocks__

stevehanson

Great work!

codeofdiego self-assigned this Feb 27, 2024

codeofdiego marked this pull request as ready for review February 27, 2024 20:00

codeofdiego requested a review from stevehanson as a code owner February 27, 2024 20:01

codeofdiego requested review from geekiam23 and rakeshpetit February 28, 2024 14:17

stevehanson reviewed Mar 1, 2024

View reviewed changes

stevehanson reviewed Mar 8, 2024

View reviewed changes

codeofdiego force-pushed the notifications branch from 2ce91ff to 9408e41 Compare March 12, 2024 19:25

This was referenced Apr 1, 2024

Add React Navigation Bottom Tabs (rebased) #35

Merged

Add React Native tooling preferences to guides thoughtbot/guides#700

Merged

codeofdiego force-pushed the notifications branch from 6b7fe39 to ae3b440 Compare April 12, 2024 14:06

codeofdiego added 17 commits April 26, 2024 13:15

Add base notifications command

49af619

This includes the addNotifications command itself, an app.config.ts file to include the google service files without changing the contents of app.json directly and a requestNotificationPermission utility to be added separately

Create methods to add custom configurations to the app.json file

05ee78a

Remove unused app.config.ts file

20f8b2a

Add AppJson type to the addAppJsonConfig method

672c697

Add missing lodash package to merge configs together

c7026e2

Create injectHooks util to look for a CODEGEN marker and inject hooks…

2415486

… and their imports into the App.tsx file

Update AppJson type to include the required expo object

6bf73ab

Include rule to fix imports order to the eslint file.

e62a3c0

This will be necessary when dynamically adding imports to ensure the right order is kept.

Add lint fix command to eslint configuration file

b86b56d

This will help run linter after performing changes to app files

Add notifications command and template files

2356ab6

Fix eslint imports organization

8e59d05

Fix firebase plugin name typo

e9afe74

Add android and ios folders to GitIgnore when adding notification sup…

48b8786

…port

include expo-build-properties to the addDependency as well

ef9f507

Fix injectHooks to import read and write functions from the correct d…

ab6dd94

…ependency, this was causing tests to fail

Add notifications test for the standard scenario

02960f6

Fix lint

9fe86ed

codeofdiego and others added 21 commits April 26, 2024 13:26

Remove step to add ios and android folders to gitignore

b6f2817

We thought this was a bit too heavy handed and might interfere with projects that already have native changes being tracked

Add fix:eslint command

fc24120

Move the commit function to its own util so it can be used throughout…

8350d17

… the project

Add steps to provide bundle identifier and package name, also add err…

3136259

…or handling to commit actions

Improve notifications tests to consider new input steps

97436fd

Improve array merge strategy on addAppJsonConfig and add tests

399b4b4

Fix ts error

f3d3fa1

Fix expo config types and concatenation algorithm

10bd3c2

Improve hook injection to operate on arbitrary files

082ffdb

Remove package name instruction from success message

d702f7e

Improve test to verify hook import was added

a1b5d43

Update src/commands/__tests__/notifications.test.ts

4c4f93b

Co-authored-by: Stephen Hanson <[email protected]>

Update src/util/injectHooks.ts

e533e2c

Co-authored-by: Stephen Hanson <[email protected]>

Fix notifications tests not passing

b770de3

Improve injectHooks util to run lint and prettier only on passed files

622c322

Fix conflict with moving the commit util to an independent file

72b5f0c

Replace add-notifications with a specific add command.

4f384d3

Add no-interactive and bundleId options

f612f0a

Remove plugins from eslint file and add importing rules, it also fix …

4376f49

…import order in the boilerplate

Remove organize imports rules from eslint-config

55163eb

We decided to discuss it further as part of the eslint-config project instead. For now organizing impots does not affect belt functionality.

Fix imports

5cf0a36

codeofdiego force-pushed the notifications branch from 84dfc19 to 5cf0a36 Compare April 26, 2024 18:31

codeofdiego added 5 commits April 26, 2024 15:33

Remove unused type casting

ac5c122

Remove unnecessary mock;

a5dafa9

Removed the getProjectDir mock as it should be already covered by the fs-extra mock in __mocks__

Add intro confirmation before running the add notifications command

486dc93

Condense changes into a single commit

824d0ce

Fix confirm inquiry breaking notifications tests

fa10b40

stevehanson approved these changes Apr 26, 2024

View reviewed changes

codeofdiego merged commit fc43e72 into main Apr 26, 2024
2 checks passed

codeofdiego deleted the notifications branch April 26, 2024 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Push Notifications command #34

Add Push Notifications command #34

codeofdiego commented Feb 27, 2024 •

edited

Loading

stevehanson left a comment

codeofdiego commented Mar 7, 2024

stevehanson left a comment

codeofdiego commented Mar 18, 2024

stevehanson left a comment

Add Push Notifications command #34

Add Push Notifications command #34

Conversation

codeofdiego commented Feb 27, 2024 • edited Loading

stevehanson left a comment

Choose a reason for hiding this comment

codeofdiego commented Mar 7, 2024

stevehanson left a comment

Choose a reason for hiding this comment

codeofdiego commented Mar 18, 2024

stevehanson left a comment

Choose a reason for hiding this comment

codeofdiego commented Feb 27, 2024 •

edited

Loading