Add loading spinners, convert code to async #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loading spinner cannot animate when using sync code
stevehanson
force-pushed
the
loading-spinners
branch
from
5b7914c
to
a9a4d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the output of the command. It was very noisy before, and it wasn't obvious which commands the output was related to (esp. when running
create-expo-app). We might want to still preserve command output and write it to a log file.Also, we were previously using a mixture of sync and async code. This PR updates the codebase to be fully asynchronous, since the loading spinner cannot animate when using sync code.
thoughtbelt-output.mov