Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check that builds with latest Expo #19

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Add CI check that builds with latest Expo #19

merged 3 commits into from
Nov 17, 2023

Conversation

stevehanson
Copy link

@stevehanson stevehanson commented Nov 10, 2023

This PR updates CI to build and run the full CLI to create an app against the latest version of Expo. The test then cds into the new app and runs the tests and linters in the new app to verify the new app is valid.

This addresses two shortcomings of the current approach and test coverage:

  1. When the CLI creates a new app, we always use the latest create-expo-app or react-native init command. This lowers the maintenance burden of this library and ensures users always get the latest versions of RN or Expo. But it is a bit brittle, since a new RN or Expo version might potentially break the CLI. These tests provide a way to ensure the CLI still works. Eventually, I'd like to set this up to run automatically on a cadence (eg. daily). This way, we would know quickly if a new version breaks the CLI.
  2. Our current test suite does not actually run the RN or Expo CLI commands, so this provides more of an end-to-end approach

@stevehanson stevehanson merged commit ca392bf into main Nov 17, 2023
2 checks passed
@stevehanson stevehanson deleted the e2e-test branch November 17, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant