Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint path #15

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Add eslint path #15

merged 6 commits into from
Aug 18, 2023

Conversation

geekiam23
Copy link
Contributor

@geekiam23 geekiam23 commented Aug 15, 2023 •
edited
Loading

Add eslint path

  • Add ability to check if package is installed
  • Add ability to check if eslint is config in the project.

@geekiam23 geekiam23 marked this pull request as ready for review August 15, 2023 20:24
stevehanson
stevehanson approved these changes Aug 18, 2023
View reviewed changes
Copy link

@stevehanson stevehanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left one comment, but this looks good to me after that change.

src/commands/templates/eslintrc.js.eta Outdated Show resolved Hide resolved
@geekiam23 geekiam23 merged commit 14782af into run-prettier Aug 18, 2023
4 checks passed
@geekiam23 geekiam23 deleted the eslint-path branch August 18, 2023 17:07
geekiam23 added a commit that referenced this pull request Aug 18, 2023
@geekiam23
Run prettier on project. (#6)
030b4b1 
* Create command to setup prettier.

* Add eslint path (#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehanson stevehanson stevehanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geekiam23 @stevehanson