Add local IP and default gateway to network for sandbox tool #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I'm not sure I can be trusted to review C; I don't see anything that seems obviously wrong, but you may want to get somebody else to have a look at this.
That said, I'm assuming you've run it locally and this looks simple/linear enough that it's probably correct, so lgtm or whatever?
Yup. This is also copied pretty much verbatim from our internal version of this (which ultimately I'd like to de-fork if possible) so I'm pretty confident it works already. (Sadly some of the other changes are less obvious & simple, although also are working for us) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were internal TM changes that I'm trying to move back now. Basically adds a 10.x IP address and routing to it for k8s envtest which can't run on localhost.