Change iterable interface to be more flexible #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
force-pushed
the
redo-iteration
branch
from
6b09c26
to
41c7628
Compare
peterebden
commented
Sep 10, 2024
|
|
||
| remote_file( | ||
| name = "golangci-lint", | ||
| binary = True, | ||
| exported_files = ["golangci-lint-%s-${OS}-${ARCH}/golangci-lint" % GO_CI_LINT_VERSION], | ||
| extract = True, | ||
| hashes = [ |
There was a problem hiding this comment.
I'm not sure we really need the hashes on this, we don't actually build it into anything
chrisnovakovic
approved these changes
Sep 11, 2024
| } | ||
|
|
||
| // An indexable represents an object that knows its length and can be indexed into. | ||
| type indexable interface { |
There was a problem hiding this comment.
Potentially missing pyObject here?
There was a problem hiding this comment.
It doesn't really matter as such - most of the others don't have it. I'll make them consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using length + index for everything, this leverages 1.23 iterators. It doesn't really change much fundamental yet, but does move towards being able to iterate things like dicts without extra list allocations.
Benchmarks locally actually seem to do slightly better. I'm not really sure why - I don't especially expect this to improve things dramatically as is - but the main thing is it's not getting worse.