Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC keepalive parameters #318

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

peterebden
Copy link
Collaborator

Hoping that this might mitigate an issue that seems to have appeared recently where Flair ends up with an apparently dead connection to the execution server, but never realises. Because Execute RPCs have either no timeout or a very long one (because sadly you cannot set a timeout to the first RPC response on a stream), I don't think it figures out that it's wrong. This should hopefully make gRPC check it and (after a while) recycle the connection.

I haven't set PermitWithoutStream so this should only generate keepalive traffic while it's actively being used.

@peterebden peterebden merged commit 743cbb7 into thought-machine:master Jul 24, 2024
5 checks passed
@peterebden peterebden deleted the add-keepalive branch July 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants