Dont take into account context canceled and rate limit errors in redis limiter. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fische
changed the title
Liu-ko
reviewed
May 8, 2024
Liu-ko
previously approved these changes
May 8, 2024
Co-authored-by: Tatiana Iljushenko <[email protected]>
Liu-ko
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised the redis limiter takes into account context cancellation errors and bumps the rate limiter if it sees that error. With mettle workers, this wasn't a big issue, but now elan hits redis as well, clients may cancel their requests.
It seems if
Allowreturns an error, the client will report it to the Limiter as well usingReportResultwhich I wasn't expecting, so I've added the rate limit error to the ones we exclude inReportResult.This PR also includes some tests for the limiter to make sure it actually works :D