WIP: Teach Purity about instance names #302
Conversation
…ial casing instance name
| @@ -187,6 +190,7 @@ func (c *collector) LoadAllBlobs() error { | |||
| for j := 0; j < 16; j++ { | |||
| ctx, cancel := context.WithTimeout(context.Background(), 30*time.Minute) | |||
| defer cancel() | |||
| ctx = metadata.NewOutgoingContext(ctx, metadata.Pairs("mettle-caller-name", name)) | |||
There was a problem hiding this comment.
I'm not normally that person, but maybe we should have a constant for mettle-caller-name...
Or possibly a top-level variable for this Pairs instance might be easier?
There was a problem hiding this comment.
Was considering moving it into the common package and perhaps making it a gRPC interceptor.
Not sure what conventions gRPC has for naming metadata as well, almost went for mettle.tmachine.io/name, but that feels very Java/k8s.
There was a problem hiding this comment.
Keys are case insensitive and consist of ASCII letters, digits, and special characters -, _, . and must not start with grpc- (which is reserved for gRPC itself). Binary-valued keys end in -bin while ASCII-valued keys do not.
So you can't have the / at least. Lower kebab case seems normal from what I've seen.
|
I think this needed more work to actually get functional, because the REX SDK was problematic to update. |
Purity abuses the instance name for the REX Api to make Elan have special cases. Additionally, it doesn't pass through instance names through out.
Still need to re-generate the protos, and ran into some "fun".