Refactor gauge strategy #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
reviewed
Mar 3, 2024
| Name: "requests_current", | ||
| }, | ||
| func() float64 { | ||
| return float64(len(srv.jobs)) |
There was a problem hiding this comment.
this could introduce a concurrent map read / modification - if the main logic is updating it at the same time as Prometheus tries to scrape it
There was a problem hiding this comment.
D'oh. Yeah, brain did not engage on that one.
Hamishpk
approved these changes
Mar 4, 2024
fische
approved these changes
Mar 4, 2024
Hamishpk
pushed a commit
to Hamishpk/please-servers
that referenced
this pull request
Mar 7, 2024
* Refactor gauge strategy to use function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the job requests are quite a hot function, and we care only about snapshots of the requests, this refactors it to use a GuageFunc to get the length of the jobs map when it's scraped.
The registering code needs to close over the
server, which is the only slighy ugliness of this approach, especially needing to wrap withsync.Onceotherwise the tests panic.