Increase timeout for UploadIfMissing #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fische
previously approved these changes
Feb 14, 2024
Birkalo
approved these changes
Feb 14, 2024
Hamishpk
added a commit
to Hamishpk/please-servers
that referenced
this pull request
Mar 7, 2024
* Increase timeout for UploadIfMissing * bump timeout to 10 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a large frontend target outputting 200k files with a total of 3Gb in size that's constantly hitting this timeout.
This was set to an arbitrary 5 minutes so bumping it to 8 to give that action a little more time.
The real fix here is to fix the target. This is blocking urgent work so bumping this as a quick mitigation