Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lowercase names for the profiler to work. #277

Merged
merged 2 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func ServeAdmin(serviceName string, opts AdminOpts, info logging.LogLevelInfo) {
opts.Admin.Logger = logging.MustGetLoggerNamed("github.com.thought-machine.http-admin")
opts.Admin.LogInfo = info
if opts.EnableGcpProfiling {
setupProfiling(serviceName)
setupProfiling(strings.ToLower(serviceName))
}
go admin.Serve(opts.Admin)
}
Expand Down
2 changes: 1 addition & 1 deletion elan/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ modes are intended for testing only.

func main() {
_, info := cli.ParseFlagsOrDie("Elan", &opts, &opts.Logging)
go cli.ServeAdmin("Elan", opts.Admin, info)
go cli.ServeAdmin("elan", opts.Admin, info)
rpc.ServeForever(opts.GRPC, opts.Storage, opts.Parallelism, opts.DirCacheSize, int64(opts.KnownBlobCacheSize))
}
2 changes: 1 addition & 1 deletion flair/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ want to have more than the minimum number of instances of it (hopefully more tha

func main() {
_, info := cli.ParseFlagsOrDie("Flair", &opts, &opts.Logging)
go cli.ServeAdmin("Flair", opts.Admin, info)
go cli.ServeAdmin("flair", opts.Admin, info)
cr := newReplicator(opts.Geometry, opts.Replicas, opts.LoadBalance)
ar := newReplicator(opts.AssetGeometry, opts.Replicas, opts.LoadBalance)
er := newReplicator(opts.ExecutorGeometry, opts.Replicas, opts.LoadBalance)
Expand Down
2 changes: 1 addition & 1 deletion lucidity/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ to go along with Zeal, then it could refer to the GTA Lucidity in FreeSpace 2.

func main() {
_, info := cli.ParseFlagsOrDie("Lucidity", &opts, &opts.Logging)
go cli.ServeAdmin("Lucidity", opts.Admin, info)
go cli.ServeAdmin("lucidity", opts.Admin, info)
rpc.ServeForever(opts.GRPC, opts.HTTPPort, time.Duration(opts.MaxAge), opts.MinProportion, opts.IAP.Audience, opts.IAP.Users)
}
2 changes: 1 addition & 1 deletion mettle/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ updated blobs dominating much of the data downloaded.
func main() {
cmd, info := cli.ParseFlagsOrDie("Mettle", &opts, &opts.Logging)
if cmd != "one" {
go cli.ServeAdmin(fmt.Sprintf("Mettle-%s", cmd), opts.Admin, info)
go cli.ServeAdmin(fmt.Sprintf("mettle-%s", cmd), opts.Admin, info)
}

if cmd == "dual" {
Expand Down
2 changes: 1 addition & 1 deletion purity/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ retains the "personal characteristics" theme.
func main() {
cmd, info := cli.ParseFlagsOrDie("Purity", &opts, &opts.Logging)
if cmd == "periodic" {
go cli.ServeAdmin("Purity", opts.Admin, info)
go cli.ServeAdmin("purity", opts.Admin, info)
}
if err := run(cmd); err != nil {
log.Fatalf("Failed: %s", err)
Expand Down
2 changes: 1 addition & 1 deletion zeal/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ for the Paladin skill in Diablo II since its job is to bang things down as fast

func main() {
_, info := cli.ParseFlagsOrDie("Zeal", &opts, &opts.Logging)
go cli.ServeAdmin("Zeal", opts.Admin, info)
go cli.ServeAdmin("zeal", opts.Admin, info)

for domain, headers := range opts.Headers {
for name, header := range headers {
Expand Down
Loading