Add linting rules

Cargo.toml

@@ -59,3 +59,9 @@ lto = true
 # improve debug backtrace performance with color-eyre
 [profile.dev.package.backtrace]
 opt-level = 3
+
+[workspace.lints.clippy]
+explicit_iter_loop = "warn"
+question_mark = "warn"
+redundant_closure_for_method_calls = "warn"
+semicolon_if_nothing_returned = "warn"

gravel-core/Cargo.toml

@@ -17,3 +17,6 @@ thiserror.workspace = true
 
 [dev-dependencies]
 rstest.workspace = true
+
+[lints]
+workspace = true

gravel-core/src/engine.rs

@@ -88,13 +88,9 @@ impl QueryEngine {
 	/// If one is found, the keyword is stripped from the query and the
 	/// resulting new query is run against that provider only.
 	fn try_keyword_query(&self, query: &str) -> Option<QueryResult> {
-		let Some(first_word) = query.split(' ').next() else {
-			return None;
-		};
+		let first_word = query.split(' ').next()?;
 
-		let Some(provider) = self.check_keywords(first_word) else {
-			return None;
-		};
+		let provider = self.check_keywords(first_word)?;
 
 		// remove the keyword from the query
 		let new_query = &query[first_word.len()..query.len()].trim_start();

gravel-core/src/hotkeys/mod.rs

@@ -94,7 +94,7 @@ fn init_hotkeys<T: 'static + Clone + Debug>(sender: &Sender<T>, hotkeys: Vec<Hot
 fn convert_modifiers(modifiers: BitFlags<Modifier>) -> u32 {
 	let mut result = 0;
 
-	for modifier in modifiers.iter() {
+	for modifier in modifiers {
 		result |= convert_modifier(modifier);
 	}
 

gravel-frontend-fltk/Cargo.toml

@@ -13,3 +13,6 @@ serde.workspace = true
 
 [target.'cfg(windows)'.dependencies]
 winapi.workspace = true
+
+[lints]
+workspace = true

gravel-frontend-fltk/src/config.rs

@@ -6,7 +6,7 @@ pub const DEFAULT_CONFIG: &str = include_str!(concat!(env!("CARGO_MANIFEST_DIR")
 
 /// Reads the [`DeserializedLayoutConfig`] from the adapter and transforms
 /// it to the final [`Config`].
-pub fn get_config(adapter: &PluginConfigAdapter) -> Config {
+pub fn get(adapter: &PluginConfigAdapter) -> Config {
 	let config = adapter.get::<Config>(DEFAULT_CONFIG);
 
 	if config.behaviour.start_hidden && config.behaviour.exit_on_hide {
@@ -87,7 +87,7 @@ pub mod deserialize {
 	}
 
 	pub fn colors<'de, D: Deserializer<'de>>(de: D) -> Result<super::DetailedColors, D::Error> {
-		ColorVariants::deserialize(de).map(|v| v.into())
+		ColorVariants::deserialize(de).map(Into::into)
 	}
 
 	#[derive(Deserialize, Debug)]

gravel-frontend-fltk/src/lib.rs

@@ -1,6 +1,5 @@
 //! gravel's default frontend, based on fltk.
 
-use crate::config::get_config;
 use gravel_core::{config::PluginConfigAdapter, plugin::*, *};
 use implementation::FltkFrontend;
 
@@ -22,5 +21,5 @@ pub fn register_plugins(registry: &mut PluginRegistry) {
 }
 
 fn get_frontend(engine: QueryEngine, config: &PluginConfigAdapter) -> Box<dyn Frontend> {
-	Box::new(FltkFrontend::new(engine, get_config(config)))
+	Box::new(FltkFrontend::new(engine, config::get(config)))
 }

gravel-provider-calculator/Cargo.toml

@@ -13,3 +13,6 @@ serde.workspace = true
 
 [dev-dependencies]
 rstest.workspace = true
+
+[lints]
+workspace = true

gravel-provider-calculator/src/lib.rs

@@ -70,7 +70,7 @@ impl Provider for CalculatorProvider {
 		let clipboard = self.get_clipboard();
 
 		let hit = SimpleHit::new(result, self.config.subtitle.clone(), move |h, s| {
-			do_copy(clipboard.clone(), h, s)
+			do_copy(clipboard.clone(), h, s);
 		})
 		.with_score(MAX_SCORE);
 

gravel-provider-exec/Cargo.toml

@@ -12,3 +12,6 @@ serde.workspace = true
 
 [target.'cfg(windows)'.dependencies]
 winapi = { workspace = true, features = ["shellapi"] }
+
+[lints]
+workspace = true

gravel-provider-kill/Cargo.toml

@@ -19,3 +19,6 @@ winapi.workspace = true
 [target.'cfg(unix)'.dependencies]
 nix = { workspace = true, features = ["process", "signal"] }
 procfs.workspace = true
+
+[lints]
+workspace = true

gravel-provider-program/Cargo.toml

@@ -14,3 +14,6 @@ shellexpand.workspace = true
 
 [target.'cfg(unix)'.dependencies]
 freedesktop_entry_parser.workspace = true
+
+[lints]
+workspace = true

gravel-provider-program/src/windows.rs

@@ -1,5 +1,6 @@
 use crate::Config;
 use gravel_core::*;
+use std::borrow::Cow;
 use std::path::Path;
 use std::process::Command;
 use std::sync::mpsc::Sender;
@@ -10,7 +11,7 @@ pub(crate) fn get_program_paths(config: &Config) -> Vec<String> {
 
 fn expand_path(path: &String) -> Option<String> {
 	shellexpand::env(path)
-		.map(|p| p.into_owned())
+		.map(Cow::into_owned)
 		.map_err(|err| log::error!("couldn't expand shortcut_path '{path}': {err}"))
 		.ok()
 }

gravel-provider-system/Cargo.toml

@@ -13,3 +13,6 @@ serde.workspace = true
 [target.'cfg(windows)'.dependencies]
 winapi = { workspace = true, features = ["powrprof"] }
 system_shutdown.workspace = true
+
+[lints]
+workspace = true

gravel-provider-websearch/Cargo.toml

@@ -11,3 +11,6 @@ log.workspace = true
 open.workspace = true
 serde.workspace = true
 urlencoding.workspace = true
+
+[lints]
+workspace = true

gravel-provider-websearch/src/lib.rs

@@ -46,7 +46,7 @@ fn do_search(url_pattern: &str, hit: &SimpleHit, sender: &Sender<FrontendMessage
 
 	log::debug!("opening URL '{url}'");
 	if let Err(err) = open::that(url) {
-		log::error!("unable to open URL: {err}")
+		log::error!("unable to open URL: {err}");
 	}
 
 	sender.send(FrontendMessage::Hide).ok();

gravel/Cargo.toml

@@ -33,3 +33,6 @@ winapi = { workspace = true, features = ["wincon"] }
 
 [target.'cfg(unix)'.dependencies]
 exec.workspace = true
+
+[lints]
+workspace = true

gravel/src/init/single_instance.rs

@@ -3,9 +3,7 @@ use single_instance::SingleInstance;
 /// Checks for duplicate instances with the given name.
 /// If `name` is [`None`], does nothing.
 pub fn single_instance(name: Option<&str>) -> Option<SingleInstance> {
-	let Some(name) = name else {
-		return None;
-	};
+	let name = name?;
 
 	log::debug!("initializing single-instance with key {name}");