Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move layout concerns out of app.vue #99

Merged
merged 3 commits into from
Aug 25, 2024
Merged

move layout concerns out of app.vue #99

merged 3 commits into from
Aug 25, 2024

Conversation

thombruce
Copy link
Owner

@thombruce thombruce commented Aug 24, 2024

closes #98

By submitting this pull request, you agree to follow our Code of Conduct: https://github.com/thombruce/.github/blob/main/CODE_OF_CONDUCT.md


Internal use. Do not delete.

  • Tests passing
  • Coverage sufficient
  • Manual review
  • No A11y regression
  • Translations provided or not needed

@thombruce
Copy link
Owner Author

thombruce commented Aug 24, 2024

Part of the point of this work was to revert a change to scrollbar handling on non-application layouts. This is not yet done.

  • Non-application (web) layouts should have a scrollbar covering the height of the window; navbar should remain sticky, if not flex-separated

@thombruce
Copy link
Owner Author

There's a note on redirect.vue that might be worth handling here.

@thombruce thombruce merged commit 343d96d into main Aug 25, 2024
@thombruce thombruce deleted the layouts branch August 25, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Layouts Overhaul
1 participant