Protect custom resource with custom filter #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonOfRa
force-pushed
the
filtered-resource
branch
from
239cf39 to
41943db
Compare
thomasdarimont
requested changes
Jul 25, 2023
...ons/src/main/java/com/github/thomasdarimont/keycloak/custom/endpoints/filter/AuthFilter.java
Outdated
Show resolved
Hide resolved
| throw new NotAuthorizedException("Invalid or missing token"); | ||
| } | ||
|
|
||
| if (!clientPattern.matcher(accessToken.getIssuedFor()).matches()) { |
There was a problem hiding this comment.
We could have an String[] audience() attribute on the @AuthFilterBinding to control the allowed client patterns.
This would allow us to optionally specify allowed audiences on class / method level on the target resource method.
There was a problem hiding this comment.
To access the "target" method of a filtered request you could inject the ResourceInfo into the filter.
@Context
private ResourceInfo resourceInfo;
https://stackoverflow.com/questions/24145659/how-to-get-target-method-of-a-given-jax-rs-request
.../main/java/com/github/thomasdarimont/keycloak/custom/endpoints/filter/ProtectedResource.java
Outdated
Show resolved
Hide resolved
...github/thomasdarimont/keycloak/custom/endpoints/filter/ProtectedResourceProviderFactory.java
Outdated
Show resolved
Hide resolved
sonOfRa
force-pushed
the
filtered-resource
branch
from
41943db to
854222e
Compare
sonOfRa
force-pushed
the
filtered-resource
branch
from
854222e to
9d57de8
Compare
thomasdarimont
force-pushed
the
main
branch
6 times, most recently
from
b261678 to
cbc4cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for using a ContainerRequestFilter to protect a custom resource