fix: prevent a potential buffer overflow #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the total number of read octets is greater than the max return buffer size in bytes, we return a failure status (-1) instead of jumping out of the loop. Otherwise, a number larger than the maximum return buffer size might be returned upon success, which if unchecked by the caller, might cause a buffer overflow. Note that the call to `reader.read(&mut ret_buffer[total_bytes_read..])` might return a value less than or equal to the available space in ret_buffer, which would make total_bytes_read no larger than the max return buffer size. However, we'd like not to make the code safer by not depending on an assumption on the implementation of the `read` method.
Add a build check job in the sanity checks workflow.
|
Sounds good - thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the total number of read octets is greater than the max return buffer size in bytes, we return a failure status (-1) instead of jumping out of the loop. Otherwise, a number larger than the maximum return buffer size might be returned upon success, which if unchecked by the caller, might cause a buffer overflow.
Note that the call to
reader.read(&mut ret_buffer[total_bytes_read..])might return a value less than or equal to the available space in ret_buffer, which would make total_bytes_read no larger than the max return buffer size. However, we'd like to make the code safer by not depending on an assumption on the implementation of thereadmethod.