Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PayEmbed] Respect supportedTokens prop #6580

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 29, 2025


PR-Codex overview

This PR updates the BuyScreen component to respect the supportedTokens prop, allowing it to dynamically set supported destinations for buying tokens.

Detailed summary

  • Added logic to handle supportedTokens prop in BuyScreen.
  • If supportedTokens is provided, it maps through its entries to create a structured array of supported destinations.
  • Updated the supportedDestinations prop passed to BuyScreenContent to use the new structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 10:40am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 10:40am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 10:40am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 10:40am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 10:40am

@joaquim-verges joaquim-verges marked this pull request as ready for review March 29, 2025 10:32
@joaquim-verges joaquim-verges requested review from a team as code owners March 29, 2025 10:32
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 29, 2025
Copy link
Member Author

joaquim-verges commented Mar 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 164 ms (+195.43% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 227 ms (+46.9% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 100 ms (+1272.98% 🔺) 212 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+1784.84% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 132 ms (+986.2% 🔺) 519 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant