Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onramp providers page to Pay overview #5836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ianthirdweb
Copy link
Contributor

@ianthirdweb ianthirdweb commented Dec 24, 2024

Added onramp page and preferredPartner information to customization pages


PR-Codex overview

This PR introduces enhancements related to preferred onramp providers in the payment integration documentation, along with updates to the sidebar navigation structure for better organization and access to features.

Detailed summary

  • Added ## Preferred Provider sections in page.mdx files for PayEmbed and ConnectButton.
  • Included code examples for setting a preferredProvider.
  • Updated metadata in onramp-providers/page.mdx.
  • Improved sidebar structure and links for better navigation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@ianthirdweb ianthirdweb requested review from jakubkrehel and a team as code owners December 24, 2024 15:35
Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 17d5174

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 24, 2024

You must have Developer access to commit code to thirdweb on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link

graphite-app bot commented Dec 24, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 24, 2024
icon: "thirdweb",
},
title: "thirdweb Pay - Onramp Providers | thirdweb",
description: ".",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata description field contains only a period. Consider adding a descriptive summary of the onramp providers page that explains its purpose and content, which will improve SEO and provide better context in search results and link previews.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (d2af09c) to head (17d5174).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5836   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files        1102     1102           
  Lines       59202    59202           
  Branches     4885     4885           
=======================================
  Hits        32045    32045           
  Misses      26433    26433           
  Partials      724      724           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e92552b
packages 51.52% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


## Choosing a Preferred Provider

It is possible to specify a preferred onramp provider by setting the `preferredProvider` parameter in the ConnectButton, PayEmbed, or Headless Integration. Go to [customizations](../pay/customization/connectbutton#preferredProvider) for more detail, or checkout the [API Reference for preferredProvider](https://portal.thirdweb.com/references/typescript/v5/GetBuyWithFiatQuoteParams).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative path ../pay/customization/connectbutton#preferredProvider needs to be updated to ../customization/connectbutton#preferred-provider. The anchor portion of the URL should use kebab-case to match the auto-generated heading ID from the markdown processor.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 3.6 s (+21.79% 🔺) 4.5 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 8 s (+44.97% 🔺) 10.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 151 ms (-42.44% 🔽) 263 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 484 ms (+325.23% 🔺) 494 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 755 ms (+0.19% 🔺) 1.2 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant