[SDK] Feature: Basic EIP7702 Support #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 429e112 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
| from: options.from ? getAddress(options.from) : undefined, | ||
| from: | ||
| typeof options.from === "string" // Is this just an address? | ||
| ? checksumAddress(options.from) |
There was a problem hiding this comment.
Getaddress is nice because it throws if invalid input, not sure if checksum does that
| }): Promise<SignedAuthorization[]> { | ||
| const { authorizations, account } = options; | ||
|
|
||
| return Promise.all( |
There was a problem hiding this comment.
There's no way to sign multiple authorizations with one signature? Assume this will prompt multiple signatures right
| resolvePromisedValue(options.transaction.to), | ||
| resolvePromisedValue(options.transaction.accessList), | ||
| resolvePromisedValue(options.transaction.value), | ||
| resolvePromisedValue(options.transaction.authorizations), |
There was a problem hiding this comment.
You don't need this right? Weird to have this and the one below
| @@ -112,5 +128,50 @@ export async function toSerializableTransaction( | |||
| accessList, | |||
| value, | |||
| ...feeData, | |||
| // For some reason authorizationList is not getting properly typed when returned from resolveAndSignAuthorizations? | |||
There was a problem hiding this comment.
Prob because of the comment above
| async function resolveAndSignAuthorizations( | ||
| options: ToSerializableTransactionOptions, | ||
| ): Promise<SignedAuthorization[] | undefined> { | ||
| if (typeof options.transaction.authorizations === "undefined") { |
There was a problem hiding this comment.
Don't you need to resolvePromise this first?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5801 +/- ##
==========================================
+ Coverage 55.41% 55.43% +0.01%
==========================================
Files 1123 1124 +1
Lines 59708 59758 +50
Branches 5066 5076 +10
==========================================
+ Hits 33089 33128 +39
- Misses 25895 25904 +9
- Partials 724 726 +2
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
force-pushed
the
greg/tool-2477-basic-7702-support-in-ts-sdk
branch
from
55bb597 to
d59413e
Compare
joaquim-verges
approved these changes
Jan 7, 2025
gregfromstl
added
the
merge-queue
Merge activity
|
gregfromstl
force-pushed
the
greg/tool-2477-basic-7702-support-in-ts-sdk
branch
2 times, most recently
from
39fddac to
0f3da1a
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR introduces beta support for `EIP-7702` authorization lists, enhancing transaction handling and signing within the `thirdweb` library.
### Detailed summary
- Added `style` configuration in `biome.json`.
- Introduced `signAuthorization` function for EIP-7702 authorizations.
- Updated transaction preparation to include `authorizationList`.
- Added tests for `signAuthorization` and transaction serialization.
- Modified `serializeTransaction` to handle EIP-7702 transactions.
- Enhanced gas estimation and transaction preparation functions to support authorization lists.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/tool-2477-basic-7702-support-in-ts-sdk
branch
from
491b5e9 to
429e112
Compare
graphite-app
bot
deleted the
greg/tool-2477-basic-7702-support-in-ts-sdk
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces beta support for
EIP-7702authorization lists, enhancing transaction capabilities in thethirdweblibrary. It includes new types, functions, and tests related to authorization signing and transaction preparation.Detailed summary
styleconfiguration inbiome.json.signAuthorizationfunction forEIP-7702inprivate-key.ts.prepareTransactionto acceptauthorizationList.signAuthorizationand transaction serialization.EIP-7702.