Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update thirdweb to 5.90.0 #860

Merged
merged 1 commit into from
Feb 28, 2025
Merged

update thirdweb to 5.90.0 #860

merged 1 commit into from
Feb 28, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 28, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR primarily focuses on updating dependencies, particularly the thirdweb library, and making changes to the signTransaction function in the backend-wallet route to enhance transaction handling.

Detailed summary

  • Updated thirdweb dependency version from 5.89.0 to 5.90.0 in package.json and tests/e2e/package.json.
  • Added imports for Hex, prepareTransaction, and toSerializableTransaction from thirdweb in src/server/routes/backend-wallet/sign-transaction.ts.
  • Removed outdated imports for prepareTransaction, toSerializableTransaction, and Hex from thirdweb.
  • Introduced a new property type in preparedTransaction to handle transaction types.
  • Updated various dependencies in yarn.lock to their latest versions, including @radix-ui components and react-remove-scroll.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 28, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://engine-v3-test-instance-yl1c-upda-fc5f85.engine-aws-usw2.zeet.app before merging 😉

Copy link

zeet-co bot commented Feb 28, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-update-9cb7c6.engine-aws-usw2.zeet.app before merging 😉

@joaquim-verges joaquim-verges marked this pull request as ready for review February 28, 2025 21:59
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@d4mr d4mr merged commit eef9c43 into main Feb 28, 2025
7 of 8 checks passed
@d4mr d4mr deleted the update_thirdweb_to_5.90.0 branch February 28, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants