Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose cache size env var #858

Merged
merged 2 commits into from
Feb 26, 2025
Merged

expose cache size env var #858

merged 2 commits into from
Feb 26, 2025

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Feb 26, 2025

PR-Codex overview

This PR focuses on replacing hardcoded cache sizes in various components with a configurable value from the env object, specifically ACCOUNT_CACHE_SIZE. This change enhances flexibility in managing cache sizes across the application.

Detailed summary

  • Updated sdkCache in src/shared/utils/cache/get-sdk.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated walletDetailsCache in src/shared/db/wallets/get-wallet-details.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated smartWalletsCache in src/shared/utils/cache/get-smart-wallet-v5.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated webhookCache in src/shared/utils/cache/get-webhook.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated walletsCache in src/shared/utils/cache/get-wallet.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated accessTokenCache in src/shared/utils/cache/access-token.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated keypairCache in src/shared/utils/cache/keypair.ts to use env.ACCOUNT_CACHE_SIZE.
  • Added ACCOUNT_CACHE_SIZE to src/shared/utils/env.ts for configuration.
  • Updated _accountsCache in src/shared/utils/account.ts to use env.ACCOUNT_CACHE_SIZE.
  • Updated _adminAccountsCache in src/shared/utils/account.ts to use env.ACCOUNT_CACHE_SIZE.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

zeet-co bot commented Feb 26, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-env-bc1302.engine-aws-usw2.zeet.app before merging 😉

@d4mr d4mr requested a review from AmineAfia February 26, 2025 20:40
@d4mr d4mr merged commit f9d79bb into main Feb 26, 2025
5 checks passed
@d4mr d4mr deleted the pb/env-cache-size branch February 26, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants